refactor: rename UV/MVPolynomial to DenseUV/MVPolynomial #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
issues/170
branch
2 times, most recently
from
f12dd60
to
d28bd9c
Compare
Pratyush
approved these changes
May 9, 2022
mmagician
added a commit
to mmagician/poly-commit
that referenced
this pull request
Jun 30, 2022
6 tasks
weikengchen
added a commit
to arkworks-rs/poly-commit
that referenced
this pull request
Aug 26, 2022
* Rename UVPolynomial to DenseUVPolynomial needed due to arkworks-rs/algebra#412 * Fix formatting * Fix `msm` usage after `ark-ec` breaking change Use `<E::G{1,2}Projective as VariableBaseMSM>::msm_bigint` instead of `VariableBase::msm` * Removed ToBytes implementations and replaced uses of the tobytes! macro. * Update Cargo.toml * Update src/ipa_pc/mod.rs * Apply suggestions from code review * apply fmt * small change to ipa_pc open Co-authored-by: Marcin Górny <[email protected]> Co-authored-by: Weikeng Chen <[email protected]>
maramihali
pushed a commit
to cryptonetlab/poly-commit
that referenced
this pull request
Dec 8, 2022
* Rename UVPolynomial to DenseUVPolynomial needed due to arkworks-rs/algebra#412 * Fix formatting * Fix `msm` usage after `ark-ec` breaking change Use `<E::G{1,2}Projective as VariableBaseMSM>::msm_bigint` instead of `VariableBase::msm` * Removed ToBytes implementations and replaced uses of the tobytes! macro. * Update Cargo.toml * Update src/ipa_pc/mod.rs * Apply suggestions from code review * apply fmt * small change to ipa_pc open Co-authored-by: Marcin Górny <[email protected]> Co-authored-by: Weikeng Chen <[email protected]>
maramihali
pushed a commit
to cryptonetlab/poly-commit
that referenced
this pull request
Dec 8, 2022
* Rename UVPolynomial to DenseUVPolynomial needed due to arkworks-rs/algebra#412 * Fix formatting * Fix `msm` usage after `ark-ec` breaking change Use `<E::G{1,2}Projective as VariableBaseMSM>::msm_bigint` instead of `VariableBase::msm` * Removed ToBytes implementations and replaced uses of the tobytes! macro. * Update Cargo.toml * Update src/ipa_pc/mod.rs * Apply suggestions from code review * apply fmt * small change to ipa_pc open Co-authored-by: Marcin Górny <[email protected]> Co-authored-by: Weikeng Chen <[email protected]>
maramihali
pushed a commit
to cryptonetlab/poly-commit
that referenced
this pull request
Dec 8, 2022
* Rename UVPolynomial to DenseUVPolynomial needed due to arkworks-rs/algebra#412 * Fix formatting * Fix `msm` usage after `ark-ec` breaking change Use `<E::G{1,2}Projective as VariableBaseMSM>::msm_bigint` instead of `VariableBase::msm` * Removed ToBytes implementations and replaced uses of the tobytes! macro. * Update Cargo.toml * Update src/ipa_pc/mod.rs * Apply suggestions from code review * apply fmt * small change to ipa_pc open Co-authored-by: Marcin Górny <[email protected]> Co-authored-by: Weikeng Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer